New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
nexus: 3.52.0-01 -> 3.62.0-01 #271120
base: master
Are you sure you want to change the base?
nexus: 3.52.0-01 -> 3.62.0-01 #271120
Conversation
Update nexus. On the way, move from binary based derivation to a source-building derivation. This should allow for more flexibility in the future, including allowing plugins to be built.
Nice! Great job in moving this to building from source. Looking at the change, how is the yarn lock v1 generated? Are you considering automating this process through an update script so that we get "free" updates for that too? |
There is a comment decribing how to generate the yarn.lock. I don't think it's worth automating as it is literaly a single operation. |
I don't think it's a blocker for this PR, but the reasoning to avoid automating it is IMHO poor. Also updating a binary package is only "one operation" (clone nixpkgs, zero out the hash, update the version, run the build, copy-paste the updated hash), but when there are 80k packages to regularly update, having it automated makes sense, especially as there's a bot that does it. Nexus shouldn't be an exception. To update the
If you have a look at other update scripts, you see they take similar steps in doing custom update processes. Also related to the |
Can you point me at an example update script so that I can crib? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3648 |
Update nexus. On the way, move from binary based derivation to a source-building derivation. This should allow for more flexibility in the future, including allowing plugins to be built.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Priorities
Add a 馃憤 reaction to pull requests you find important.